-
Notifications
You must be signed in to change notification settings - Fork 40
Allow installation of extra platform plugins #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is essentially code from #89 but refactored to address review requests. I checked that indeed it does deploy extra platform plugins and the final AppImage works |
Tagging @TheAssassin |
I'm just wondering, but why do we need |
@bjorn Apparently, yes. linuxdeploy-plugin-qt/src/qt-modules.h Line 21 in dc2e5b7
Actually |
@TheAssassin will you be able to review this? Thanks! |
@TheAssassin gently ping |
I think this was just taken over from linuxdeployqt. We should think about correcting this. Mind to open an issue? |
0038984
to
c20ae97
Compare
Haven't tested this extensively, but the code looks good and on a first try it seems to do the trick. Thanks @asl! |
Resolves #88